[PATCH v3 hmm 10/12] mm/hmm: Do not use list*_rcu() for hmm->ranges

Jason Gunthorpe jgg at ziepe.ca
Fri Jun 14 00:44:48 UTC 2019

From: Jason Gunthorpe <jgg at mellanox.com>

This list is always read and written while holding hmm->lock so there is
no need for the confusing _rcu annotations.

Signed-off-by: Jason Gunthorpe <jgg at mellanox.com>
Reviewed-by: Jérôme Glisse <jglisse at redhat.com>
Reviewed-by: John Hubbard <jhubbard at nvidia.com>
Acked-by: Souptick Joarder <jrdr.linux at gmail.com>
Reviewed-by: Ralph Campbell <rcampbell at nvidia.com>
Acked-by: Souptick Joarder <jrdr.linux at gmail.com>
Reviewed-by: Ira Weiny <iweiny at intel.com>
Tested-by: Philip Yang <Philip.Yang at amd.com>
 mm/hmm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/hmm.c b/mm/hmm.c
index e214668cba3474..26af511cbdd075 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -908,7 +908,7 @@ int hmm_range_register(struct hmm_range *range,
 	range->hmm = hmm;
-	list_add_rcu(&range->list, &hmm->ranges);
+	list_add(&range->list, &hmm->ranges);
 	 * If there are any concurrent notifiers we have to wait for them for
@@ -934,7 +934,7 @@ void hmm_range_unregister(struct hmm_range *range)
 	struct hmm *hmm = range->hmm;
-	list_del_rcu(&range->list);
+	list_del(&range->list);
 	/* Drop reference taken by hmm_range_register() */

More information about the amd-gfx mailing list