[PATCH] drm/amdgpu: wait to fetch the vbios until after common init

[Christian König]

A quick guide to the different tags:

Signed-off-by: I'm somehow responsible that the code is in the mainline 
tree. E.g. either the Author of a patch or some maintainer who forwarded 
the stuff to Linus.
Tested-by: I tested the code and found it working good.
Reviewed-by: I'm familiar with both the code and the hardware and judged 
that this looks like it should work as intended.
Acked-by: It looks good to me in general, but I'm not familiar with 
either the code or the hardware to judge if that is correct or not. 
Usually used to note general agreement to a design or piece of code 
without looking to deeply into it.

NAK means a fundamental disagreement on how a piece of code implements 
something and what a reviewer things is the right thing to do. It is 
something which needs to sorted out before some code can be committed.

A NAK does NOT mean general rejection, but rather that you need to 
retreat and start discussion things on a higher level.

Christian.

Am 17.06.19 um 17:26 schrieb Russell, Kent:
>
> Thanks, I need to get familiar with all of the tags 😊
>
> Kent
>
> *From:* Deucher, Alexander <Alexander.Deucher at amd.com>
> *Sent:* Monday, June 17, 2019 11:24 AM
> *To:* Russell, Kent <Kent.Russell at amd.com>; Alex Deucher 
> <alexdeucher at gmail.com>; amd-gfx at lists.freedesktop.org
> *Subject:* Re: [PATCH] drm/amdgpu: wait to fetch the vbios until after 
> common init
>
> I'll make that a tested-by.  Thanks!
>
> Alex
>
> ------------------------------------------------------------------------
>
> *From:*Russell, Kent
> *Sent:* Monday, June 17, 2019 11:14 AM
> *To:* Alex Deucher; amd-gfx at lists.freedesktop.org 
> <mailto:amd-gfx at lists.freedesktop.org>
> *Cc:* Deucher, Alexander
> *Subject:* RE: [PATCH] drm/amdgpu: wait to fetch the vbios until after 
> common init
>
> This also worked. I don't think that I'm qualified enough to RB it, 
> but you can add my
>
> Verified-By: Kent Russell <kent.russell at amd.com 
> <mailto:kent.russell at amd.com>>
>
>  Kent
>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org 
> <mailto:amd-gfx-bounces at lists.freedesktop.org>> On Behalf Of Alex Deucher
> Sent: Monday, June 17, 2019 10:45 AM
> To: amd-gfx at lists.freedesktop.org <mailto:amd-gfx at lists.freedesktop.org>
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com 
> <mailto:Alexander.Deucher at amd.com>>
> Subject: [PATCH] drm/amdgpu: wait to fetch the vbios until after 
> common init
>
> We need the asic_funcs set for the get rom callbacks in some cases.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com 
> <mailto:alexander.deucher at amd.com>>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 24 ++++++++++++----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 4a836db1000f..e26303bc567e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1534,17 +1534,6 @@ static int amdgpu_device_ip_early_init(struct 
> amdgpu_device *adev)
>          if (amdgpu_sriov_vf(adev))
>                  adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
>
> -       /* Read BIOS */
> -       if (!amdgpu_get_bios(adev))
> -               return -EINVAL;
> -
> -       r = amdgpu_atombios_init(adev);
> -       if (r) {
> -               dev_err(adev->dev, "amdgpu_atombios_init failed\n");
> -               amdgpu_vf_error_put(adev, 
> AMDGIM_ERROR_VF_ATOMBIOS_INIT_FAIL, 0, 0);
> -               return r;
> -       }
> -
>          for (i = 0; i < adev->num_ip_blocks; i++) {
>                  if ((amdgpu_ip_block_mask & (1 << i)) == 0) {
>                          DRM_ERROR("disabled ip block: %d <%s>\n", @@ 
> -1566,6 +1555,19 @@ static int amdgpu_device_ip_early_init(struct 
> amdgpu_device *adev)
> adev->ip_blocks[i].status.valid = true;
>                          }
>                  }
> +               /* get the vbios after the asic_funcs are set up */
> +               if (adev->ip_blocks[i].version->type == 
> AMD_IP_BLOCK_TYPE_COMMON) {
> +                       /* Read BIOS */
> +                       if (!amdgpu_get_bios(adev))
> +                               return -EINVAL;
> +
> +                       r = amdgpu_atombios_init(adev);
> +                       if (r) {
> +                               dev_err(adev->dev, 
> "amdgpu_atombios_init failed\n");
> +                               amdgpu_vf_error_put(adev, 
> AMDGIM_ERROR_VF_ATOMBIOS_INIT_FAIL, 0, 0);
> +                               return r;
> +                       }
> +               }
>          }
>
>          adev->cg_flags &= amdgpu_cg_mask;
> --
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org <mailto:amd-gfx at lists.freedesktop.org>
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190617/74ee31da/attachment.html>