[PATCH 105/459] drm/amdgpu/discovery: stop converting the units of base addresses

Alex Deucher alexdeucher at gmail.com
Mon Jun 17 19:11:06 UTC 2019


From: Xiaojie Yuan <xiaojie.yuan at amd.com>

the unit is already in dword

Signed-off-by: Xiaojie Yuan <xiaojie.yuan at amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>
Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 5f967ae8d4ed..697800c4741f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -300,11 +300,11 @@ int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev)
 
 					for (k = 0; k < num_base_address; k++) {
 						/*
-						 * convert the endianness and unit (in dword) of base addresses in place,
+						 * convert the endianness of base addresses in place,
 						 * so that we don't need to convert them when accessing adev->reg_offset.
 						 */
-						ip->base_address[k] = le32_to_cpu(ip->base_address[k]) >> 2;
-						DRM_DEBUG("\t0x%08x\n", ip->base_address[k] << 2);
+						ip->base_address[k] = le32_to_cpu(ip->base_address[k]);
+						DRM_DEBUG("\t0x%08x\n", ip->base_address[k]);
 					}
 
 					adev->reg_offset[hw_ip][ip->number_instance] =
-- 
2.20.1



More information about the amd-gfx mailing list