[PATCH 201/459] drm/amdgpu: fix memory leak in preemption unit test

Alex Deucher alexdeucher at gmail.com
Mon Jun 17 19:29:28 UTC 2019


From: Jack Xiao <Jack.Xiao at amd.com>

It forgot to put job fence, caused fence memory leak.

Signed-off-by: Jack Xiao <Jack.Xiao at amd.com>
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
index 28614dd05f88..4997efa09ce7 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
@@ -968,10 +968,12 @@ static void amdgpu_ib_preempt_signal_fences(struct dma_fence **fences,
 static void amdgpu_ib_preempt_job_recovery(struct drm_gpu_scheduler *sched)
 {
 	struct drm_sched_job *s_job;
+	struct dma_fence *fence;
 
 	spin_lock(&sched->job_list_lock);
 	list_for_each_entry(s_job, &sched->ring_mirror_list, node) {
-		sched->ops->run_job(s_job);
+		fence = sched->ops->run_job(s_job);
+		dma_fence_put(fence);
 	}
 	spin_unlock(&sched->job_list_lock);
 }
-- 
2.20.1



More information about the amd-gfx mailing list