[PATCH] drm/amdgpu: add job->preamble_status back to status value

Christian König ckoenig.leichtzumerken at gmail.com
Tue Jun 18 11:10:07 UTC 2019


Am 18.06.19 um 12:31 schrieb Xiao, Jack:
> job->preamble_status was accidently dropped from the combination value
> of status varaiable which is the parameter of some ring level function.
> The patch is to add it back.
>
> Signed-off-by: Jack Xiao <Jack.Xiao at amd.com>

For now Acked-by: Christian König <christian.koenig at amd.com>, cause we 
need to get this fixed ASAP.

But now the question is why do we actually have two fields in the job 
for the same status?

Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> index 90cc084..6882eeb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
> @@ -208,6 +208,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
>   
>   	skip_preamble = ring->current_ctx == fence_ctx;
>   	if (job && ring->funcs->emit_cntxcntl) {
> +		status |= job->preamble_status;
>   		status |= job->preemption_status;
>   		amdgpu_ring_emit_cntxcntl(ring, status);
>   	}



More information about the amd-gfx mailing list