[PATCH] drm/amdkfd: Set gws_mask to 64 bit 1s

Kuehling, Felix Felix.Kuehling at amd.com
Thu Jun 20 21:18:15 UTC 2019


On 2019-06-14 11:59 a.m., Zeng, Oak wrote:
> Previous kfd doesn't use gws so this mask was set to 0.
> Set it to 64 bit 1s because now kfd can use all 64 gws
> resources.
>
> Change-Id: Ic8217d6d135099f3395017bbc9c0fe94a739aa93
> Signed-off-by: Oak Zeng <Oak.Zeng at amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index e5c6db1..250798b 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -993,8 +993,8 @@ static int set_sched_resources(struct device_queue_manager *dqm)
>   
>   		res.queue_mask |= (1ull << i);
>   	}
> -	res.gws_mask = res.oac_mask = res.gds_heap_base =
> -						res.gds_heap_size = 0;
> +	res.gws_mask = 0xFFFFFFFFFFFFFFFF;

I think this is correct (counting 16 Fs). But if you want to set all 64 
bits, ~0ull may be less error prone.

Either way, this patch is Reviewed-by: Felix Kuehling 
<Felix.Kuehling at amd.com>

> +	res.oac_mask = res.gds_heap_base = res.gds_heap_size = 0;
>   
>   	pr_debug("Scheduling resources:\n"
>   			"vmid mask: 0x%8X\n"


More information about the amd-gfx mailing list