[PATCH] drm/amdgpu: Fix lockdep warking more gracely
Pan, Xinhui
Xinhui.Pan at amd.com
Mon Mar 11 11:57:05 UTC 2019
lockdep need a static key.
Previously we set ignore bit to avoid the warning.
Now call sysfs_attr_init to initialize the static key.
Signed-off-by: xinhui pan <xinhui.pan at amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 1acaa8473629..1f47974b1184 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -748,12 +748,10 @@ static int amdgpu_ras_sysfs_create_feature_node(struct amdgpu_device *adev)
.attr = {
.name = "features",
.mode = S_IRUGO,
-#ifdef CONFIG_DEBUG_LOCK_ALLOC
- .ignore_lockdep = 1,
-#endif
},
.show = amdgpu_ras_sysfs_features_read,
};
+ sysfs_attr_init(attrs[0]);
return sysfs_create_group(&adev->dev->kobj, &group);
}
@@ -793,12 +791,10 @@ int amdgpu_ras_sysfs_create(struct amdgpu_device *adev,
.attr = {
.name = obj->fs_data.sysfs_name,
.mode = S_IRUGO,
-#ifdef CONFIG_DEBUG_LOCK_ALLOC
- .ignore_lockdep = 1,
-#endif
},
.show = amdgpu_ras_sysfs_read,
};
+ sysfs_attr_init(&obj->sysfs_attr.attr);
if (sysfs_add_file_to_group(&adev->dev->kobj,
&obj->sysfs_attr.attr,
--
2.17.1
More information about the amd-gfx
mailing list