[PATCH 1/2] drm/amdgpu: let ras initialization a little noticeable

Deucher, Alexander Alexander.Deucher at amd.com
Tue Mar 12 13:44:02 UTC 2019


Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
________________________________
From: Pan, Xinhui
Sent: Tuesday, March 12, 2019 6:13 AM
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander; Quan, Evan; Zhang, Hawking
Subject: [PATCH 1/2] drm/amdgpu: let ras initialization a little noticeable

add drm info output if ras initialized successfully.
add ras atomfirmware sanity check.

Signed-off-by: xinhui pan <xinhui.pan at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 1f47974b1184..10ce40d2c040 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1357,8 +1357,9 @@ static void amdgpu_ras_check_supported(struct amdgpu_device *adev,
                         adev->asic_type != CHIP_VEGA20)
                 return;

-       if (amdgpu_atomfirmware_mem_ecc_supported(adev) ||
-                       amdgpu_atomfirmware_sram_ecc_supported(adev))
+       if (adev->is_atom_fw &&
+                       (amdgpu_atomfirmware_mem_ecc_supported(adev) ||
+                        amdgpu_atomfirmware_sram_ecc_supported(adev)))
                 *hw_supported = AMDGPU_RAS_BLOCK_MASK;

         *supported = amdgpu_ras_enable == 0 ?
@@ -1398,6 +1399,10 @@ int amdgpu_ras_init(struct amdgpu_device *adev)
                 goto fs_out;

         amdgpu_ras_self_test(adev);
+
+       DRM_INFO("RAS INFO: ras initialized successfully, "
+                       "hardware ability[%x] ras_mask[%x]\n",
+                       con->hw_supported, con->supported);
         return 0;
 fs_out:
         amdgpu_ras_recovery_fini(adev);
--
2.17.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190312/fb0232fd/attachment-0001.html>


More information about the amd-gfx mailing list