[PATCH] drm/amdgpu: revert "cleanup setting bulk_movable"

Michel Dänzer michel at daenzer.net
Wed Mar 13 09:03:06 UTC 2019


On 2019-03-13 9:38 a.m., Christian König wrote:
> This reverts commit 4ef27005fefd4be102010b7d8552fec1ee13435a.
> 
> It can trigger a reference counter bug in TTM. Need to investigate further, but
> for now revert the offending change.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 8603c85985b5..84409c9738cf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -693,6 +693,8 @@ int amdgpu_vm_validate_pt_bos(struct amdgpu_device *adev, struct amdgpu_vm *vm,
>  	struct amdgpu_vm_bo_base *bo_base, *tmp;
>  	int r = 0;
>  
> +	vm->bulk_moveable &= list_empty(&vm->evicted);
> +
>  	list_for_each_entry_safe(bo_base, tmp, &vm->evicted, vm_status) {
>  		struct amdgpu_bo *bo = bo_base->bo;
>  
> 

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
Tested-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list