[PATCH] drm/amd/amdgpu: fix Polaris10 PCIe dpm feature issue.

[Gui, Jack]

Hi Alex,

Expand the fix to all asics, please help to review.

BR,
Jack Gui

-----Original Message-----
From: Alex Deucher <alexdeucher at gmail.com> 
Sent: Thursday, March 21, 2019 9:24 PM
To: Gui, Jack <Jack.Gui at amd.com>
Cc: amd-gfx list <amd-gfx at lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/amdgpu: fix Polaris10 PCIe dpm feature issue.

On Thu, Mar 21, 2019 at 1:35 AM Chengming Gui <Jack.Gui at amd.com> wrote:
>
> use pcie_bandwidth_available to get real link state to update pcie 
> table.
>
> Signed-off-by: Chengming Gui <Jack.Gui at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 964a4d3..df8e58b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3649,7 +3649,9 @@ static void 
> amdgpu_device_get_min_pci_speed_width(struct amdgpu_device *adev,  {
>         struct pci_dev *pdev = adev->pdev;
>         enum pci_bus_speed cur_speed;
> +       enum pci_bus_speed tmp_speed;
>         enum pcie_link_width cur_width;
> +       u32 ret = 0;
>
>         *speed = PCI_SPEED_UNKNOWN;
>         *width = PCIE_LNK_WIDTH_UNKNOWN; @@ -3657,6 +3659,11 @@ static 
> void amdgpu_device_get_min_pci_speed_width(struct amdgpu_device *adev,
>         while (pdev) {
>                 cur_speed = pcie_get_speed_cap(pdev);
>                 cur_width = pcie_get_width_cap(pdev);
> +               if (adev->asic_type == CHIP_POLARIS10)
> +                       ret = pcie_bandwidth_available(adev->pdev, NULL,
> +                                                      &tmp_speed, 
> + &cur_width);

Any reason to not just do this for all asics?

Alex

> +               if (!ret)
> +                       cur_width = PCIE_LNK_WIDTH_RESRV;
>
>                 if (cur_speed != PCI_SPEED_UNKNOWN) {
>                         if (*speed == PCI_SPEED_UNKNOWN)
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-amd-amdgpu-fix-PCIe-dpm-feature-issue-v3.patch
Type: application/octet-stream
Size: 1566 bytes
Desc: 0001-drm-amd-amdgpu-fix-PCIe-dpm-feature-issue-v3.patch
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190322/4d730742/attachment.obj>