[PATCH] drm/amd/powerplay: check for invalid profile_exit setting

[Zhou1, Tao]

Reviewed-by: Tao Zhou <tao.zhou1 at amd.com>

> -----Original Message-----
> From: Evan Quan <evan.quan at amd.com>
> Sent: 2019年5月5日 11:20
> To: amd-gfx at lists.freedesktop.org
> Cc: Zhou1, Tao <Tao.Zhou1 at amd.com>; Quan, Evan <Evan.Quan at amd.com>
> Subject: [PATCH] drm/amd/powerplay: check for invalid profile_exit setting
> 
> profile_exit performance level setting is valid only when current mode is in
> profile mode.
> 
> Change-Id: I6940102d38dbb7a4b0233fce5277e1704672d8f4
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index b80873348624..df78372296bf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -404,6 +404,16 @@ static ssize_t
> amdgpu_set_dpm_forced_performance_level(struct device *dev,
>  	if (current_level == level)
>  		return count;
> 
> +	/* profile_exit setting is valid only when current mode is in profile
> mode */
> +	if (!(current_level &
> (AMD_DPM_FORCED_LEVEL_PROFILE_STANDARD |
> +	    AMD_DPM_FORCED_LEVEL_PROFILE_MIN_SCLK |
> +	    AMD_DPM_FORCED_LEVEL_PROFILE_MIN_MCLK |
> +	    AMD_DPM_FORCED_LEVEL_PROFILE_PEAK)) &&
> +	    (level == AMD_DPM_FORCED_LEVEL_PROFILE_EXIT)) {
> +		pr_err("Currently not in any profile mode!\n");
> +		return -EINVAL;
> +	}
> +
>  	if (is_support_sw_smu(adev)) {
>  		mutex_lock(&adev->pm.mutex);
>  		if (adev->pm.dpm.thermal_active) {
> --
> 2.21.0