Compiler warnings with current amd-staging-drm-next

Michel Dänzer michel at daenzer.net
Thu May 16 09:24:27 UTC 2019


On 2019-05-10 1:17 p.m., Michel Dänzer wrote:
> 
> drivers/gpu/drm//amd/amdgpu/df_v3_6.c: In function ‘df_v3_6_pmc_start’:
> drivers/gpu/drm//amd/amdgpu/df_v3_6.c:482:9: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return ret;
>          ^~~

This warning is still there; the others have been fixed.


Other warnings have been introduced though:

drivers/gpu/drm//amd/amdgpu/../powerplay/vega20_ppt.c: In function ‘vega20_get_ppfeature_status’:
drivers/gpu/drm//amd/amdgpu/../powerplay/vega20_ppt.c:2387:103: warning: ‘feature_mask’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  *features_enabled = ((((uint64_t)feature_mask[0] << SMU_FEATURES_LOW_SHIFT) & SMU_FEATURES_LOW_MASK) |
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
    (((uint64_t)feature_mask[1] << SMU_FEATURES_HIGH_SHIFT) & SMU_FEATURES_HIGH_MASK));
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                  
drivers/gpu/drm//amd/amdgpu/../powerplay/vega20_ppt.c: In function ‘vega20_set_ppfeature_status’:
drivers/gpu/drm//amd/amdgpu/../powerplay/vega20_ppt.c:2387:103: warning: ‘feature_mask’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  *features_enabled = ((((uint64_t)feature_mask[0] << SMU_FEATURES_LOW_SHIFT) & SMU_FEATURES_LOW_MASK) |
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
    (((uint64_t)feature_mask[1] << SMU_FEATURES_HIGH_SHIFT) & SMU_FEATURES_HIGH_MASK));
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                  


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list