[PATCH 3/7] drm/dp-mst: Use connector kdev as aux device parent

Lyude Paul lyude at redhat.com
Thu May 16 20:23:18 UTC 2019


On Thu, 2019-05-16 at 11:17 -0400, sunpeng.li at amd.com wrote:
> From: Leo Li <sunpeng.li at amd.com>
> 
> Placing the MST aux device as a child of the connector gives udev the
> ability to access the connector device's attributes. This will come in
> handy when writing udev rules to create more descriptive symlinks to the
> MST aux devices.
> 
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Lyude Paul <lyude at redhat.com>
> Signed-off-by: Leo Li <sunpeng.li at amd.com>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 54da68e..cd2f3c4 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1269,6 +1269,9 @@ static void drm_dp_add_port(struct drm_dp_mst_branch
> *mstb,
>  		}
>  		(*mstb->mgr->cbs->register_connector)(port->connector);
>  
> +		if (port->connector->registration_state ==
> DRM_CONNECTOR_REGISTERED)
> +			port->aux.dev = port->connector->kdev;
> +

Line wrapping please! Probably worth running checkpatch on all of these
patches as well.

With that nitpick addressed:

Reviewed-by: Lyude Paul <lyude at redhat.com>

>  		drm_dp_aux_register_devnode(&port->aux);
>  	}
>  
-- 
Cheers,
	Lyude Paul



More information about the amd-gfx mailing list