[PATCH] drm/amd/powerplay: fix sw SMU wrong UVD/VCE powergate setting

[Xu, Feifei]

Reviewed-by: Feifei Xu <Feifei.Xu at amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Evan Quan
Sent: Friday, May 17, 2019 1:45 PM
To: amd-gfx at lists.freedesktop.org
Cc: Quan, Evan <Evan.Quan at amd.com>
Subject: [PATCH] drm/amd/powerplay: fix sw SMU wrong UVD/VCE powergate setting

[CAUTION: External Email]

The UVD/VCE bits are set wrongly. This causes the UVD/VCE clocks are not brought back correctly on needed.

Change-Id: I6eda67ea3be45fd5f422cdb78356915bf06ff41e
Signed-off-by: Evan Quan <evan.quan at amd.com>
---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
index 0eea93c8dff7..a3a7afca7516 100644
--- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
+++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
@@ -1814,24 +1814,24 @@ static int smu_v11_0_update_od8_settings(struct smu_context *smu,

 static int smu_v11_0_dpm_set_uvd_enable(struct smu_context *smu, bool enable)  {
-       if (!smu_feature_is_supported(smu, FEATURE_DPM_VCE_BIT))
+       if (!smu_feature_is_supported(smu, FEATURE_DPM_UVD_BIT))
                return 0;

-       if (enable == smu_feature_is_enabled(smu, FEATURE_DPM_VCE_BIT))
+       if (enable == smu_feature_is_enabled(smu, FEATURE_DPM_UVD_BIT))
                return 0;

-       return smu_feature_set_enabled(smu, FEATURE_DPM_VCE_BIT, enable);
+       return smu_feature_set_enabled(smu, FEATURE_DPM_UVD_BIT, 
+ enable);
 }

 static int smu_v11_0_dpm_set_vce_enable(struct smu_context *smu, bool enable)  {
-       if (!smu_feature_is_supported(smu, FEATURE_DPM_UVD_BIT))
+       if (!smu_feature_is_supported(smu, FEATURE_DPM_VCE_BIT))
                return 0;

-       if (enable == smu_feature_is_enabled(smu, FEATURE_DPM_UVD_BIT))
+       if (enable == smu_feature_is_enabled(smu, FEATURE_DPM_VCE_BIT))
                return 0;

-       return smu_feature_set_enabled(smu, FEATURE_DPM_UVD_BIT, enable);
+       return smu_feature_set_enabled(smu, FEATURE_DPM_VCE_BIT, 
+ enable);
 }

 static int smu_v11_0_get_current_rpm(struct smu_context *smu,
--
2.21.0

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx