[PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output

Harry Wentland hwentlan at amd.com
Fri Nov 1 15:13:09 UTC 2019


On 2019-10-30 2:58 p.m., neil at neil.mayhew.name wrote:
> From: Neil Mayhew <neil at neil.mayhew.name>

This requires your Signed-off-by. See [1].

With that fixed your change looks good and is
Reviewed-by: Harry Wentland <harry.wentland at amd.com>

You can simply reply to this email with your Signed-off-by and I can add
it when merging, or you can send a v2 patch with your Signed-off-by.

[1]
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Harry

> 
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index a52f0b13a2c8..f802c784e6f6 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4114,8 +4114,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
>  		result = MODE_OK;
>  	else
>  		DRM_DEBUG_KMS("Mode %dx%d (clk %d) failed DC validation with error %d\n",
> -			      mode->vdisplay,
>  			      mode->hdisplay,
> +			      mode->vdisplay,
>  			      mode->clock,
>  			      dc_result);
>  
> 


More information about the amd-gfx mailing list