[PATCH 2/2] drm/amdgpu: add warning for GRBM 1-cycle delay issue in gfx9

Koenig, Christian Christian.Koenig at amd.com
Tue Nov 5 11:55:14 UTC 2019


Am 05.11.19 um 12:42 schrieb Zhu, Changfeng:
> From: changzhu <Changfeng.Zhu at amd.com>
>
> It needs to add warning to update firmware in gfx9
> in case that firmware is too old to have function to
> realize dummy read in cp firmware.
>
> Change-Id: I6aef94f0823138f244f1eedb62fde833dd697023
> Signed-off-by: changzhu <Changfeng.Zhu at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com> for this one.

> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 9d5f900e3e1c..f2deb225c8a9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -982,6 +982,13 @@ static void gfx_v9_0_check_fw_write_wait(struct amdgpu_device *adev)
>   	adev->gfx.me_fw_write_wait = false;
>   	adev->gfx.mec_fw_write_wait = false;
>   
> +	if ((adev->gfx.mec_fw_version < 0x000001a5) ||
> +	    (adev->gfx.mec_feature_version < 46) ||
> +	    (adev->gfx.pfp_fw_version < 0x000000b7) ||
> +	    (adev->gfx.pfp_feature_version < 46))
> +		DRM_WARN_ONCE("Warning: check cp_fw_version and update it to realize \
> +						GRBM requires 1-cycle delay in cp firmware\n");
> +
>   	switch (adev->asic_type) {
>   	case CHIP_VEGA10:
>   		if ((adev->gfx.me_fw_version >= 0x0000009c) &&



More information about the amd-gfx mailing list