[PATCH] drm/amd/powerplay: correct Arcturus OD support

Feng, Kenneth Kenneth.Feng at amd.com
Fri Nov 8 02:44:57 UTC 2019


Reviewed-by: Kenneth Feng <kenneth.feng at amd.com>


-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Quan, Evan
Sent: Thursday, November 7, 2019 3:39 PM
To: amd-gfx at lists.freedesktop.org
Cc: Li, Candice <Candice.Li at amd.com>; Quan, Evan <Evan.Quan at amd.com>; Freehill, Chris <Chris.Freehill at amd.com>
Subject: [PATCH] drm/amd/powerplay: correct Arcturus OD support

[CAUTION: External Email]

OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs interface is also not supported.

Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf
Signed-off-by: Evan Quan <evan.quan at amd.com>
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index c21fe7ac5df8..76a4154b3be2 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev)  {
        struct smu_context *smu = &adev->smu;

+       if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
+               smu->od_enabled = true;
+
        switch (adev->asic_type) {
        case CHIP_VEGA20:
                vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev)
                break;
        case CHIP_ARCTURUS:
                arcturus_set_ppt_funcs(smu);
+               /* OD is not supported on Arcturus */
+               smu->od_enabled =false;
                break;
        case CHIP_RENOIR:
                renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev)
                return -EINVAL;
        }

-       if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
-               smu->od_enabled = true;
-
        return 0;
 }

--
2.23.0

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list