[PATCH] drm/amdgpu/powerplay/smu7: fix AVFS handling with custom powerplay table

[Quan, Evan]

Reviewed-by: Evan Quan <evan.quan at amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: Saturday, November 9, 2019 12:18 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> Subject: [PATCH] drm/amdgpu/powerplay/smu7: fix AVFS handling with custom
> powerplay table
> 
> When a custom powerplay table is provided, we need to update the OD VDDC
> flag to avoid AVFS being enabled when it shouldn't be.
> 
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=205393
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index c805c6fcdba2..390e7524bef4 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -3969,6 +3969,13 @@ static int smu7_set_power_state_tasks(struct
> pp_hwmgr *hwmgr, const void *input)
>  			"Failed to populate and upload SCLK MCLK DPM
> levels!",
>  			result = tmp_result);
> 
> +	/*
> +	 * If a custom pp table is loaded, set DPMTABLE_OD_UPDATE_VDDC
> flag.
> +	 * That effectively disables AVFS feature.
> +	 */
> +	if (hwmgr->hardcode_pp_table != NULL)
> +		data->need_update_smu7_dpm_table |=
> DPMTABLE_OD_UPDATE_VDDC;
> +
>  	tmp_result = smu7_update_avfs(hwmgr);
>  	PP_ASSERT_WITH_CODE((0 == tmp_result),
>  			"Failed to update avfs voltages!",
> --
> 2.23.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx