[PATCH 2/2] drm/amd/display: Fix coding error in connector atomic check

Kazlauskas, Nicholas nicholas.kazlauskas at amd.com
Tue Nov 12 16:06:47 UTC 2019


On 2019-11-12 10:15 a.m., mikita.lipski at amd.com wrote:
> From: Mikita Lipski <mikita.lipski at amd.com>
> 
> [why]
> For MST connector atomic check we have to check a new CRTC state
> instead of an old one, when checking if CRTC is disabled to
> release VCPI slots allocated.
> 
> Signed-off-by: Mikita Lipski <mikita.lipski at amd.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 21f09b61ee88..00cb2f109853 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -299,7 +299,7 @@ static int dm_dp_mst_atomic_check(struct drm_connector *connector,
>   		return 0;
>   
>   	if (new_conn_state->crtc) {
> -		new_crtc_state = drm_atomic_get_old_crtc_state(state, new_conn_state->crtc);
> +		new_crtc_state = drm_atomic_get_new_crtc_state(state, new_conn_state->crtc);
>   		if (!new_crtc_state ||
>   		    !drm_atomic_crtc_needs_modeset(new_crtc_state) ||
>   		    new_crtc_state->enable)
> 



More information about the amd-gfx mailing list