[PATCH 00/21] Separate JPEG from VCN
Leo Liu
leo.liu at amd.com
Tue Nov 12 20:16:42 UTC 2019
On 2019-11-12 3:12 p.m., Alex Deucher wrote:
> On Tue, Nov 12, 2019 at 2:57 PM Leo Liu <leo.liu at amd.com> wrote:
>>
>> On 2019-11-12 2:49 p.m., Alex Deucher wrote:
>>> On Tue, Nov 12, 2019 at 1:03 PM Leo Liu <leo.liu at amd.com> wrote:
>>>> From JPEG2.0, JPEG is a separated IP block, and has it own PG/CG,
>>>> and power management. It doesn't require FW, so indepedent from FW
>>>> loading as well.
>>>>
>>>> Patch 1-4: Separate JPEG1.0 from SW wise, since JPEG1.0 is still
>>>> combined with VCN1.0 esp. in power management;
>>>> Patch 5-10: Separate JPEG2.0 as an independent IP with PG/CG;
>>>> Patch 11-15: Add power management for JPEG of Navi1x and Renoir;
>>>> Patch 16: Enable JPEG2.0;
>>>> Patch 17-20: Separate JPEG2.5 from VCN2.5;
>>>> Patch 21: Enable JPEG2.5
>>>>
>>> Is the jpeg powergating dynamic or do we need a idle work thread to
>>> turn it off like we do for vcn?
>> It has static PG/CG for JPEG2.0 and static CG for JPEG2.5.
>>
>> It also has DPM for JPEG2.0. So we need idle work thread and begin_use
>> like VCN to init/deinit JPEG and turn on/off JPEG power through SMU
>> messages such as PowerUPJpeg and PowerDownJpeg.
> Ok, so that still has to be implemented then. I didn't see that in
> the patch set.
"amdgpu_jpeg_idle_work_handler" is in patch 6, and calling those SMU messages are in those powerplay patches.
The set is complete for all JPEGs
Thanks,
Leo
> Thanks,
>
> Alex
>
>>
>> Thanks,
>> Leo
>>
>>
>>> Alex
>>>
>>>> Leo Liu (21):
>>>> drm/amdgpu: add JPEG HW IP and SW structures
>>>> drm/amdgpu: add amdgpu_jpeg and JPEG tests
>>>> drm/amdgpu: separate JPEG1.0 code out from VCN1.0
>>>> drm/amdgpu: use the JPEG structure for general driver support
>>>> drm/amdgpu: add JPEG IP block type
>>>> drm/amdgpu: add JPEG common functions to amdgpu_jpeg
>>>> drm/amdgpu: add JPEG v2.0 function supports
>>>> drm/amdgpu: remove unnecessary JPEG2.0 code from VCN2.0
>>>> drm/amdgpu: add JPEG PG and CG interface
>>>> drm/amdgpu: add PG and CG for JPEG2.0
>>>> drm/amd/powerplay: add JPEG Powerplay interface
>>>> drm/amd/powerplay: add JPEG power control for Navi1x
>>>> drm/amd/powerplay: add Powergate JPEG for Renoir
>>>> drm/amd/powerplay: add JPEG power control for Renoir
>>>> drm/amd/powerplay: set JPEG to SMU dpm
>>>> drm/amdgpu: enable JPEG2.0 dpm
>>>> drm/amdgpu: add driver support for JPEG2.0 and above
>>>> drm/amdgpu: enable JPEG2.0 for Navi1x and Renoir
>>>> drm/amdgpu: move JPEG2.5 out from VCN2.5
>>>> drm/amdgpu: enable Arcturus CG for VCN and JPEG blocks
>>>> drm/amdgpu: enable Arcturus JPEG2.5 block
>>>>
>>>> drivers/gpu/drm/amd/amdgpu/Makefile | 8 +-
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 +-
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 215 +++++
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 62 ++
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 15 +-
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 8 +
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h | 1 +
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 113 +--
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 -
>>>> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c | 584 +++++++++++++
>>>> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.h | 32 +
>>>> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 827 ++++++++++++++++++
>>>> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h | 42 +
>>>> drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 641 ++++++++++++++
>>>> drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.h | 29 +
>>>> drivers/gpu/drm/amd/amdgpu/nv.c | 11 +-
>>>> drivers/gpu/drm/amd/amdgpu/soc15.c | 10 +-
>>>> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 481 +---------
>>>> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 496 +----------
>>>> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.h | 13 -
>>>> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 246 +-----
>>>> drivers/gpu/drm/amd/include/amd_shared.h | 5 +-
>>>> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 5 +
>>>> .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 3 +
>>>> drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 2 +
>>>> drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 32 +-
>>>> drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 27 +
>>>> drivers/gpu/drm/amd/powerplay/smu_internal.h | 4 +
>>>> drivers/gpu/drm/amd/powerplay/smu_v12_0.c | 11 +
>>>> 31 files changed, 2593 insertions(+), 1346 deletions(-)
>>>> create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c
>>>> create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h
>>>> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c
>>>> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.h
>>>> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c
>>>> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h
>>>> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c
>>>> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.h
>>>>
>>>> --
>>>> 2.17.1
>>>>
>>>> _______________________________________________
>>>> amd-gfx mailing list
>>>> amd-gfx at lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
More information about the amd-gfx
mailing list