[PATCH] drm/amd/display: Modify comments to match the code

Zhan Liu zhan.liu at amd.com
Fri Nov 15 23:03:21 UTC 2019


[Why]
This line of code was modified. However, the comment
was remaining unchanged.

[How]
Change "200ms" to "3000ms", which matches the code.
Also add another line of comment, which tells people where
the value came from.

Signed-off-by: Zhan Liu <zhan.liu at amd.com>
---
 drivers/gpu/drm/amd/display/dc/dc_helper.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dc_helper.c b/drivers/gpu/drm/amd/display/dc/dc_helper.c
index 8da4576e2908..4973d50c4fb9 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_helper.c
+++ b/drivers/gpu/drm/amd/display/dc/dc_helper.c
@@ -485,7 +485,11 @@ void generic_reg_wait(const struct dc_context *ctx,
 		return;
 	}
 
-	/* something is terribly wrong if time out is > 200ms. (5Hz) */
+	/* 
+	 * Something is terribly wrong if time out is > 3000ms.
+	 * 3000ms is defined by SMU timeout value.
+	 *
+	 */
 	ASSERT(delay_between_poll_us * time_out_num_tries <= 3000000);
 
 	for (i = 0; i <= time_out_num_tries; i++) {
-- 
2.17.1



More information about the amd-gfx mailing list