[PATCH] drm/amdgpu: remove not needed memset

Alex Deucher alexdeucher at gmail.com
Mon Nov 18 17:26:10 UTC 2019


Applied.  thanks!

Alex

On Mon, Nov 18, 2019 at 10:07 AM zhengbin <zhengbin13 at huawei.com> wrote:
>
> Fixes coccicheck warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c:64:13-31: WARNING: dma_alloc_coherent use in ih -> ring already zeroes out memory,  so memset is not needed
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: zhengbin <zhengbin13 at huawei.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c
> index 6d8f055..111a301 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c
> @@ -66,7 +66,6 @@ int amdgpu_ih_ring_init(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih,
>                 if (ih->ring == NULL)
>                         return -ENOMEM;
>
> -               memset((void *)ih->ring, 0, ih->ring_size + 8);
>                 ih->gpu_addr = dma_addr;
>                 ih->wptr_addr = dma_addr + ih->ring_size;
>                 ih->wptr_cpu = &ih->ring[ih->ring_size / 4];
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list