[PATCH] drm/amd/display: add default clocks if not able to fetch them

Alex Deucher alexdeucher at gmail.com
Fri Nov 22 18:09:24 UTC 2019


Ping?

On Tue, Nov 19, 2019 at 3:56 PM Alex Deucher <alexdeucher at gmail.com> wrote:
>
> dm_pp_get_clock_levels_by_type needs to add the default clocks
> to the powerplay case as well.  This was accidently dropped.
>
> Fixes: b3ea88fef321de ("drm/amd/powerplay: add get_clock_by_type interface for display")
> Bug: https://gitlab.freedesktop.org/drm/amd/issues/906
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c
> index 229788bee544..a2e1a73f66b8 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c
> @@ -342,7 +342,8 @@ bool dm_pp_get_clock_levels_by_type(
>         if (adev->powerplay.pp_funcs && adev->powerplay.pp_funcs->get_clock_by_type) {
>                 if (adev->powerplay.pp_funcs->get_clock_by_type(pp_handle,
>                         dc_to_pp_clock_type(clk_type), &pp_clks)) {
> -               /* Error in pplib. Provide default values. */
> +                       /* Error in pplib. Provide default values. */
> +                       get_default_clock_levels(clk_type, dc_clks);
>                         return true;
>                 }
>         } else if (adev->smu.ppt_funcs && adev->smu.ppt_funcs->get_clock_by_type) {
> --
> 2.23.0
>


More information about the amd-gfx mailing list