[PATCH 10/10 v2] drm/amdgpu: reduce redundant uvd context lost warning message

[Ma, Le]

-----Original Message-----
From: Christian König <ckoenig.leichtzumerken at gmail.com>
Sent: Wednesday, November 27, 2019 6:08 PM
To: Ma, Le <Le.Ma at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Chen, Guchun <Guchun.Chen at amd.com>; Zhou1, Tao <Tao.Zhou1 at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Li, Dennis <Dennis.Li at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>
Subject: Re: [PATCH 10/10 v2] drm/amdgpu: reduce redundant uvd context lost warning message



Am 27.11.19 um 11:02 schrieb Le Ma:

> Move the print out of uvd instance loop in amdgpu_uvd_suspend

>

> v2: drop unnecessary brackets

>

> Change-Id: Ifad997debd84763e1b55d668e144b729598f115e

> Signed-off-by: Le Ma <le.ma at amd.com<mailto:le.ma at amd.com>>

> ---

>   drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 10 ++++++----

>   1 file changed, 6 insertions(+), 4 deletions(-)

>

> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c

> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c

> index e324bfe..69248ecb 100644

> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c

> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c

> @@ -376,13 +376,15 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev)

>                                  return -ENOMEM;

>

>                      /* re-write 0 since err_event_athub will corrupt VCPU buffer */

> -                   if (amdgpu_ras_intr_triggered()) {

> -                               DRM_WARN("UVD VCPU state may lost due to RAS ERREVENT_ATHUB_INTERRUPT\n");

> +                  if (amdgpu_ras_intr_triggered())



Can the state change while doing the loop? If yes than I would rather grab that once and use it multiple times.



Christian.



[Le]: Got your meaning, and the state will not change here. Will update this in v3.



>                                  memset(adev->uvd.inst[j].saved_bo, 0, size);

> -                   } else {

> +                  else

>                                  memcpy_fromio(adev->uvd.inst[j].saved_bo, ptr, size);

> -                   }

>          }

> +

> +      if (amdgpu_ras_intr_triggered())

> +                  DRM_WARN("UVD VCPU state may lost due to RAS

> +ERREVENT_ATHUB_INTERRUPT\n");

> +

>          return 0;

>   }

>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20191127/b838f060/attachment.html>