[PATCH 4/5] drm/amdgpu: use CPU to flush vmhub if sched stopped

[Liu, Monk]

Christian 

>> Good catch, but you are somehow messing up the indentation here.
I cannot align with the indentation, because my coding style check script (we use it to push code to gerritgit) requires me to use "tab" instead of "space"
It means the current coding style is in fact wrong .... 
_____________________________________
Monk Liu|GPU Virtualization Team |AMD


-----Original Message-----
From: Christian König <ckoenig.leichtzumerken at gmail.com> 
Sent: Tuesday, November 26, 2019 8:20 PM
To: Liu, Monk <Monk.Liu at amd.com>; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/amdgpu: use CPU to flush vmhub if sched stopped

Am 26.11.19 um 12:50 schrieb Monk Liu:
> otherwse the flush_gpu_tlb will hang if we unload the KMD becuase the 
> schedulers already stopped
>
> Signed-off-by: Monk Liu <Monk.Liu at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c 
> b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index 321f8a9..4bb4d27 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -326,7 +326,8 @@ static void gmc_v10_0_flush_gpu_tlb(struct 
> amdgpu_device *adev, uint32_t vmid,
>   
>   	if (!adev->mman.buffer_funcs_enabled ||
>   	    !adev->ib_pool_ready ||
> -	    adev->in_gpu_reset) {
> +	    adev->in_gpu_reset ||
> +		ring->sched.ready == false) {

Good catch, but you are somehow messing up the indentation here.

With that fixed the patch is Reviewed-by: Christian König <christian.koenig at amd.com>

>   		gmc_v10_0_flush_vm_hub(adev, vmid, AMDGPU_GFXHUB_0, 0);
>   		mutex_unlock(&adev->mman.gtt_window_lock);
>   		return;