[PATCH 2/2] drm/amdkfd: Print more sdma engine hqds in debug fs

Kuehling, Felix Felix.Kuehling at amd.com
Fri Oct 4 14:55:06 UTC 2019


On 2019-10-04 10:48, Zeng, Oak wrote:
> Previously only PCIe-optimized SDMA engine hqds were
> exposed in debug fs. Print all SDMA engine hqds.
>
> Change-Id: I03756fc0fa99169d88e265560f505ed186242b02
> Reported-by: Jonathan Kim <Jonathan.Kim at amd.com>
> Signed-off-by: Jonathan Kim <Jonathan.Kim at amd.com>
> Signed-off-by: Oak Zeng <Oak.Zeng at amd.com>
Minor cosmetic nit-pick inline that checkpatch.pl would probably warn 
about. With that fixed, this patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index e55d021..0ebc604 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -2416,7 +2416,7 @@ int dqm_debugfs_hqds(struct seq_file *m, void *data)
>   		}
>   	}
>   
> -	for (pipe = 0; pipe < get_num_sdma_engines(dqm); pipe++) {
> +	for (pipe = 0; pipe < get_num_sdma_engines(dqm) + get_num_xgmi_sdma_engines(dqm); pipe++) {

This line looks longer than 80 characters. Try to find a good place to 
break it.


>   		for (queue = 0;
>   		     queue < dqm->dev->device_info->num_sdma_queues_per_engine;
>   		     queue++) {


More information about the amd-gfx mailing list