[PATCH 02/19] drm/amdgpu: add supports_baco callback for soc15 asics.

Alex Deucher alexdeucher at gmail.com
Sun Oct 13 16:50:05 UTC 2019


On Sat, Oct 12, 2019 at 7:45 AM Lukas Wunner <lukas at wunner.de> wrote:
>
> On Thu, Oct 10, 2019 at 08:45:19PM -0500, Alex Deucher wrote:
> > Check the BACO capabilities from the powerplay table.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> [...]
> > @@ -997,6 +1020,7 @@ static const struct amdgpu_asic_funcs vega20_asic_funcs =
> >       .read_bios_from_rom = &soc15_read_bios_from_rom,
> >       .read_register = &soc15_read_register,
> >       .reset = &soc15_asic_reset,
> > +     .reset_method = &soc15_asic_reset_method,
> >       .set_vga_state = &soc15_vga_set_state,
> >       .get_xclk = &soc15_get_xclk,
> >       .set_uvd_clocks = &soc15_set_uvd_clocks,
> > @@ -1009,7 +1033,7 @@ static const struct amdgpu_asic_funcs vega20_asic_funcs =
> >       .get_pcie_usage = &vega20_get_pcie_usage,
> >       .need_reset_on_init = &soc15_need_reset_on_init,
> >       .get_pcie_replay_count = &soc15_get_pcie_replay_count,
> > -     .reset_method = &soc15_asic_reset_method
>
> Seemingly unrelated change without explanation.

Just moves the setting of that callback to better align with the
struct definition and other other structs defined in this fine.  I can
drop it.

Alex


More information about the amd-gfx mailing list