[PATCH] drm/amdgpu: No need to check gfxoff status after enable gfxoff feature

[Wang, Kevin(Yang)]

comment inline.
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of chen gong <curry.gong at amd.com>
Sent: Monday, October 14, 2019 10:57 AM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Gong, Curry <Curry.Gong at amd.com>
Subject: [PATCH] drm/amdgpu: No need to check gfxoff status after enable gfxoff feature

smu_send_smc_msg(smu, SMU_MSG_AllowGfxOff) Just turn on a switch.

As to when GPU get into "GFXoff" will be up to drawing load.

So we can not sure which state GPU should be in after enable gfxoff
feature.

Signed-off-by: chen gong <curry.gong at amd.com>
---
 drivers/gpu/drm/amd/powerplay/smu_v12_0.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/smu_v12_0.c b/drivers/gpu/drm/amd/powerplay/smu_v12_0.c
index c9691d0..cac4269 100644
--- a/drivers/gpu/drm/amd/powerplay/smu_v12_0.c
+++ b/drivers/gpu/drm/amd/powerplay/smu_v12_0.c
@@ -244,15 +244,6 @@ static int smu_v12_0_gfx_off_control(struct smu_context *smu, bool enable)
         if (enable) {
                 ret = smu_send_smc_msg(smu, SMU_MSG_AllowGfxOff);

-               /* confirm gfx is back to "off" state, timeout is 5 seconds */
-               while (!(smu_v12_0_get_gfxoff_status(smu) == 0)) {
-                       msleep(10);
-                       timeout--;
[kevin]:
the varible of "timeout" is not used after this patch, please remove it together.
after fixed.
Reviewed-by: Kevin Wang <kevin1.wang at amd.com>

-                       if (timeout == 0) {
-                               DRM_ERROR("enable gfxoff timeout and failed!\n");
-                               break;
-                       }
-               }
         } else {
                 ret = smu_send_smc_msg(smu, SMU_MSG_DisallowGfxOff);

--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20191015/50790de1/attachment-0001.html>