[PATCH v5 00/14] DP MST Refactors + debugging tools + suspend/resume reprobing

Lyude Paul lyude at redhat.com
Tue Oct 22 02:35:55 UTC 2019


This is the final portion of the large series for adding MST
suspend/resume reprobing that I've been working on for quite a while
now. In addition, I:

* Refactored and cleaned up any code I ended up digging through in the
  process of understanding how some parts of these helpers worked.
* Added some debugging tools along the way that I ended up needing to
  figure out some issues in my own code

Note that there's still one important part of this process missing
that's not included in this patch series: EDID reprobing, which I
believe Stanislav Lisovskiy from Intel is currently working on. The main
purpose of this series is to fix the issue of the in-memory topology
state (e.g. connectors connected to an MST hub, branch devices, etc.)
going out of sync if a topology connected to a connector is swapped out
with a different topology while the system is resumed, or while the
device housing said connector is in runtime suspend.

As well, the debugging tools that are added in this include:
* A limited debugging utility for dumping the list of topology
  references on an MST port or branch connector whose topology reference
  count has reached 0
<sideband message dumping has been merged :)>

Lyude Paul (14):
  drm/dp_mst: Destroy MSTBs asynchronously
  drm/dp_mst: Remove PDT teardown in drm_dp_destroy_port() and refactor
  drm/dp_mst: Refactor pdt setup/teardown, add more locking
  drm/dp_mst: Handle UP requests asynchronously
  drm/dp_mst: Add probe_lock
  drm/dp_mst: Protect drm_dp_mst_port members with locking
  drm/dp_mst: Don't forget to update port->input in
    drm_dp_mst_handle_conn_stat()
  drm/dp_mst: Lessen indenting in drm_dp_mst_topology_mgr_resume()
  drm/nouveau: Don't grab runtime PM refs for HPD IRQs
  drm/nouveau: Resume hotplug interrupts earlier
  drm/amdgpu: Iterate through DRM connectors correctly
  drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topology
  drm/dp_mst: Add basic topology reprobing when resuming
  drm/dp_mst: Add topology ref history tracking for debugging

 drivers/gpu/drm/Kconfig                       |   14 +
 .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    |   13 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   20 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   |    5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c  |   40 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c       |    5 +-
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c        |   34 +-
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c        |   34 +-
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |   40 +-
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         |   34 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   41 +-
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c |   10 +-
 .../display/amdgpu_dm/amdgpu_dm_mst_types.c   |   28 +-
 drivers/gpu/drm/drm_dp_mst_topology.c         | 1185 +++++++++++++----
 drivers/gpu/drm/i915/display/intel_dp.c       |    3 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   28 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |   38 +-
 drivers/gpu/drm/nouveau/nouveau_connector.c   |   33 +-
 drivers/gpu/drm/nouveau/nouveau_display.c     |   19 +-
 drivers/gpu/drm/radeon/radeon_dp_mst.c        |   24 +-
 include/drm/drm_dp_mst_helper.h               |  160 ++-
 21 files changed, 1329 insertions(+), 479 deletions(-)

-- 
2.21.0



More information about the amd-gfx mailing list