[PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

Jason Gunthorpe jgg at mellanox.com
Mon Oct 21 19:12:23 UTC 2019


On Wed, Oct 16, 2019 at 06:35:15AM +0000, Oleksandr Andrushchenko wrote:
> On 10/16/19 8:11 AM, Jürgen Groß wrote:
> > On 15.10.19 20:12, Jason Gunthorpe wrote:
> >> From: Jason Gunthorpe <jgg at mellanox.com>
> >>
> >> DMA_SHARED_BUFFER can not be enabled by the user (it represents a 
> >> library
> >> set in the kernel). The kconfig convention is to use select for such
> >> symbols so they are turned on implicitly when the user enables a kconfig
> >> that needs them.
> >>
> >> Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable.
> >>
> >> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI")
> >> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com>
> >> Cc: Boris Ostrovsky <boris.ostrovsky at oracle.com>
> >> Cc: xen-devel at lists.xenproject.org
> >> Cc: Juergen Gross <jgross at suse.com>
> >> Cc: Stefano Stabellini <sstabellini at kernel.org>
> >> Signed-off-by: Jason Gunthorpe <jgg at mellanox.com>
> >
> > Reviewed-by: Juergen Gross <jgross at suse.com>
> >
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com>

Thanks Oleksandr and Juergen, can you also give me some advice on how
to progress the more complex patch:

https://patchwork.kernel.org/patch/11191369/

Is this gntdev stuff still in-use? I struggled a bit to understand
what it is doing, but I think I made a reasonable guess?

Jason


More information about the amd-gfx mailing list