[PATCH 4/4] drm/amdgpu: remove ras global recovery handling from ras_controller_int handler

[Ma, Le]

-----Original Message-----
From: Chen, Guchun <Guchun.Chen at amd.com>
Sent: Tuesday, October 29, 2019 9:37 AM
To: Ma, Le <Le.Ma at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Ma, Le <Le.Ma at amd.com>
Subject: RE: [PATCH 4/4] drm/amdgpu: remove ras global recovery handling from ras_controller_int handler









Regards,

Guchun



-----Original Message-----

From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org<mailto:amd-gfx-bounces at lists.freedesktop.org>> On Behalf Of Le Ma

Sent: Monday, October 28, 2019 7:31 PM

To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>

Cc: Ma, Le <Le.Ma at amd.com<mailto:Le.Ma at amd.com>>

Subject: [PATCH 4/4] drm/amdgpu: remove ras global recovery handling from ras_controller_int handler



From: Le Ma <Le.Ma at amd.com<mailto:Le.Ma at amd.com>>



Change-Id: Ia8a61a4b3bd529f0f691e43e69b299d7d151c0c2

Signed-off-by: Le Ma <Le.Ma at amd.com<mailto:Le.Ma at amd.com>>

---

drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 6 +++++-

1 file changed, 5 insertions(+), 1 deletion(-)



diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c

index 0db458f..876690a 100644

--- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c

+++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c

@@ -324,7 +324,11 @@ static void nbio_v7_4_handle_ras_controller_intr_no_bifring(struct amdgpu_device

                                                                       RAS_CNTLR_INTERRUPT_CLEAR, 1);

                       WREG32_SOC15(NBIO, 0, mmBIF_DOORBELL_INT_CNTL, bif_doorbell_intr_cntl);

-                       amdgpu_ras_global_ras_isr(adev);

+                      /*

+                      * ras_controller_int is dedicated for nbif ras error,

+                      * not the global interrupt for sync flood

+                      */

+                      amdgpu_ras_reset_gpu(adev, true);

[Guchun]We need to add one printing here to tell audience, who and why resets gpu? And moreover, in the removed global ras isr handler amdgpu_ras_global_ras_isr, we call amdgpu_ras_reset_gpu with is_baco parameter "false", but now we use "true" here?

[Le] We may consider add printing here to indicate it’s ras controller interrupt issue. The is_baco parameter is unused and has no effect. Anyway, I will revise and hold on patch #2 and #4 when baco based RAS recovery totally works as Hawking’s comment.

           }

}

--

2.7.4



_______________________________________________

amd-gfx mailing list

amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>

https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20191029/0abc1d59/attachment-0001.html>