[PATCH 2/3] drm/amdgpu: Remove clock gating restore.

[Chen, Guchun]

Reviewed-by: Guchun Chen <guchun.chen at amd.com>
Tested-by: Guchun Chen <guchun.chen at amd.com>


-----Original Message-----
From: Andrey Grodzovsky <andrey.grodzovsky at amd.com> 
Sent: Thursday, September 5, 2019 10:50 AM
To: amd-gfx at lists.freedesktop.org
Cc: alexdeucher at gmail.com; Zhang, Hawking <Hawking.Zhang at amd.com>; Zhou1, Tao <Tao.Zhou1 at amd.com>; Chen, Guchun <Guchun.Chen at amd.com>; Saceleanu, Cristian <Cristian.Saceleanu at amd.com>; Grodzovsky, Andrey <Andrey.Grodzovsky at amd.com>
Subject: [PATCH 2/3] drm/amdgpu: Remove clock gating restore.

Restoring clock gating break SMU opeartion afterwards, avoid this until this further invistigated with SMU.

Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c b/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c
index 7d0d4c5..95266fe 100644
--- a/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c
+++ b/drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c
@@ -491,7 +491,15 @@ static void smu_v11_0_i2c_fini(struct i2c_adapter *control)
 	}
 
 	/* Restore clock gating */
-	smu_v11_0_i2c_set_clock_gating(control, true);
+
+	/*
+	 *TODO Reenabling clock gating seems to break subsequent SMU operation
+	 *on the I2C bus. My guess is that SMU doesn't disable clock gating like
+	 *we do here before working with the bus. So for now just don't restore
+	 *it but later work with SMU to see if they have this issue and can
+	 *update their code appropriately
+	 */
+	/* smu_v11_0_i2c_set_clock_gating(control, true); */
 
 }
 
--
2.7.4