drm/amdgpu: remove the redundant null check

Markus Elfring Markus.Elfring at web.de
Wed Sep 4 17:50:35 UTC 2019


> debugfs_remove and kfree has taken the null check in account.
> hence it is unnecessary to check it. Just remove the condition.

How do you think about a wording like the following?

  The functions “debugfs_remove” and “kfree” tolerate the passing
  of null pointers. Hence it is unnecessary to check such arguments
  around the calls. Thus remove the extra condition check at two places.


> No functional change.

I find this information questionable while it is partly reasonable
according to the shown software refactoring.

Can a subject like “[PATCH] drm/amdgpu: Remove two redundant
null pointer checks” be nicer here?


Were any source code analysis tools involved for finding
these update candidates?

Regards,
Markus


More information about the amd-gfx mailing list