Re：[PATCH] drm/amdgpu: resvert "disable bulk moves for now"

[Dieter Nützel]

Hello Christian and David,

I've running Alex's 'amd-staging-drm-next' with it enabled.
Great numbers with vkmark (radv) and glmark2.

Sadly 'amd-staging-drm-next' still stands on 5.2.0-rc1 - no changes 
during the last 2 weeks.
Is Alex on vacation/traveling?

Greetings,
Dieter

[-]
Zhou, David(ChunMing) David1.Zhou at amd.com
Thu Sep 12 15:18:43 UTC 2019

I dont know dkms status，anyway, we should submit this one as early as 
possible.

-------- 原始邮件 --------
主题：Re: [PATCH] drm/amdgpu: resvert "disable bulk moves for now"
发件人：Christian König
收件人："Zhou, David(ChunMing)" ,amd-gfx at lists.freedesktop.org
抄送：

Just to double check: We do have that enabled in the DKMS package for a
while and doesn't encounter any more problems with it, correct?

Thanks,
Christian.

Am 12.09.19 um 16:02 schrieb Chunming Zhou:
> RB on it to go ahead.
> 
> -David
> 
> 在 2019/9/12 18:15, Christian König 写道:
>> This reverts commit a213c2c7e235cfc0e0a161a558f7fdf2fb3a624a.
>> 
>> The changes to fix this should have landed in 5.1.
>> 
>> Signed-off-by: Christian König <christian.koenig at amd.com>
>> ---
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 --
>>    1 file changed, 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index 48349e4f0701..fd3fbaa73fa3 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -603,14 +603,12 @@ void amdgpu_vm_move_to_lru_tail(struct 
>> amdgpu_device *adev,
>>       struct ttm_bo_global *glob = adev->mman.bdev.glob;
>>       struct amdgpu_vm_bo_base *bo_base;
>> 
>> -#if 0
>>       if (vm->bulk_moveable) {
>>               spin_lock(&glob->lru_lock);
>>               ttm_bo_bulk_move_lru_tail(&vm->lru_bulk_move);
>>               spin_unlock(&glob->lru_lock);
>>               return;
>>       }
>> -#endif
>> 
>>       memset(&vm->lru_bulk_move, 0, sizeof(vm->lru_bulk_move));
>>