[PATCH] drm/amdkfd: Delete unused KFD_IS_DGPU macro

Kuehling, Felix Felix.Kuehling at amd.com
Mon Sep 16 17:41:15 UTC 2019


On 2019-09-16 12:26 p.m., wrote:
> This was deleted before, but somehow showed up again. Delete it again.
>
> Change-Id: I19b3063932380cb74a01d505e8e92f897a2c2cb7
> Signed-off-by: Yong Zhao <Yong.Zhao at amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> index 06bb2d7a9b39..6ed31a76dfda 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> @@ -180,9 +180,6 @@ enum cache_policy {
>   };
>   
>   #define KFD_IS_VI(chip) ((chip) >= CHIP_CARRIZO && (chip) <= CHIP_POLARIS11)
> -#define KFD_IS_DGPU(chip) (((chip) >= CHIP_TONGA && \
> -			   (chip) <= CHIP_NAVI10) || \
> -			   (chip) == CHIP_HAWAII)

Are you familiar with "git blame"? It's really useful to track down 
which commit introduced code. In this case it shows that both IS_DGPU 
and IS_VI were added back by Philip Cox in his Navi10 change, probably 
accidentally while resolving a rebase conflict. You can probably remove 
IS_VI as well.

Regards,
   Felix


>   #define KFD_IS_SOC15(chip) ((chip) >= CHIP_VEGA10)
>   
>   struct kfd_event_interrupt_class {


More information about the amd-gfx mailing list