[PATCH 1/2] drm/amdgpu: use PAGE_SHIFT rather than PAGE_SIZE to get the shift

[Christian König]

Am 16.09.19 um 20:43 schrieb Alex Deucher:
> Looks like a copy and paste typo.
>
> Fixes: 0d9a80213829 ("drm/amdgpu: cleanup creating BOs at fixed location")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com> for the series.

Sorry for the noise, I don't have hardware to actually test that :(

And BTW: Shouldn't this be AMDGPU_PAGE_SIZE/SHIFT?

Thanks,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index be49419778db..ff1fc084ffe1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -1409,7 +1409,7 @@ int amdgpu_ras_reserve_bad_pages(struct amdgpu_device *adev)
>   	for (i = data->last_reserved; i < data->count; i++) {
>   		bp = data->bps[i].retired_page;
>   
> -		if (amdgpu_bo_create_kernel_at(adev, bp << PAGE_SIZE, PAGE_SIZE,
> +		if (amdgpu_bo_create_kernel_at(adev, bp << PAGE_SHIFT, PAGE_SIZE,
>   					       AMDGPU_GEM_DOMAIN_VRAM,
>   					       &bo, NULL))
>   			DRM_ERROR("RAS ERROR: reserve vram %llx fail\n", bp);