[PATCH] drm/amdgpu/ras: use GPU PAGE_SIZE/SHIFT for reserving pages

Christian König ckoenig.leichtzumerken at gmail.com
Tue Sep 17 08:09:21 UTC 2019


Am 16.09.19 um 21:50 schrieb Alex Deucher:
> We are reserving vram pages so they should be aligned to the
> GPU page size.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index ff1fc084ffe1..131c53fa8eff 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -1409,7 +1409,8 @@ int amdgpu_ras_reserve_bad_pages(struct amdgpu_device *adev)
>   	for (i = data->last_reserved; i < data->count; i++) {
>   		bp = data->bps[i].retired_page;
>   
> -		if (amdgpu_bo_create_kernel_at(adev, bp << PAGE_SHIFT, PAGE_SIZE,
> +		if (amdgpu_bo_create_kernel_at(adev, bp << AMDGPU_GPU_PAGE_SHIFT,
> +					       AMDGPU_GPU_PAGE_SIZE,
>   					       AMDGPU_GEM_DOMAIN_VRAM,
>   					       &bo, NULL))
>   			DRM_ERROR("RAS ERROR: reserve vram %llx fail\n", bp);



More information about the amd-gfx mailing list