[PATCH] drm/amdgpu/psp: dont warn on missing optional TA's

Nirmoy nirmodas at amd.com
Fri Apr 3 16:41:34 UTC 2020


On 4/3/20 6:32 PM, Alex Deucher wrote:
> Replace dev_warn() with dev_info() and note that they are
> optional to avoid confusing users.
>
> The RAS TAs only exist on server boards and the HDCP and DTM
> TAs only exist on client boards.  They are optional either way.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>


Acked-by: Nirmoy Das <nirmoy.das at amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index dbaeffc4431e..5d67b1838951 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -822,7 +822,7 @@ static int psp_ras_initialize(struct psp_context *psp)
>   
>   	if (!psp->adev->psp.ta_ras_ucode_size ||
>   	    !psp->adev->psp.ta_ras_start_addr) {
> -		dev_warn(psp->adev->dev, "RAS: ras ta ucode is not available\n");
> +		dev_info(psp->adev->dev, "RAS: optional ras ta ucode is not available\n");
>   		return 0;
>   	}
>   
> @@ -906,7 +906,7 @@ static int psp_hdcp_initialize(struct psp_context *psp)
>   
>   	if (!psp->adev->psp.ta_hdcp_ucode_size ||
>   	    !psp->adev->psp.ta_hdcp_start_addr) {
> -		dev_warn(psp->adev->dev, "HDCP: hdcp ta ucode is not available\n");
> +		dev_info(psp->adev->dev, "HDCP: optional hdcp ta ucode is not available\n");
>   		return 0;
>   	}
>   
> @@ -1052,7 +1052,7 @@ static int psp_dtm_initialize(struct psp_context *psp)
>   
>   	if (!psp->adev->psp.ta_dtm_ucode_size ||
>   	    !psp->adev->psp.ta_dtm_start_addr) {
> -		dev_warn(psp->adev->dev, "DTM: dtm ta ucode is not available\n");
> +		dev_info(psp->adev->dev, "DTM: optional dtm ta ucode is not available\n");
>   		return 0;
>   	}
>   


More information about the amd-gfx mailing list