AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

Masami Hiramatsu mhiramat at kernel.org
Sat Apr 4 08:32:57 UTC 2020


On Fri, 3 Apr 2020 20:15:11 -0700
Randy Dunlap <rdunlap at infradead.org> wrote:

> On 4/3/20 8:08 PM, Masami Hiramatsu wrote:
> > +static inline int insn_is_fpu(struct insn *insn)
> > +{
> > +	if (!insn->opcode.got)
> > +		insn_get_opcode(insn);
> > +	if (inat_is_fpu(insn->attr)) {
> > +		if (insn->attr & INAT_FPUIFVEX)
> > +			return insn_is_avx(insn);
> > +		return 1;
> > +	}
> 
> 	return 0; // ??

Oops, right!

Hm, I need to add a caller for this API...

Thanks,

> 
> > +}
> > +
> 
> 
> -- 
> ~Randy
> 


-- 
Masami Hiramatsu <mhiramat at kernel.org>


More information about the amd-gfx mailing list