[PATCH 30/36] drm/amd/display: Avoid create MST prop after registration

Alex Deucher alexdeucher at gmail.com
Mon Apr 6 18:54:20 UTC 2020


On Mon, Apr 6, 2020 at 2:52 PM Rodrigo Siqueira
<Rodrigo.Siqueira at amd.com> wrote:
>
> Ok, I'll just push the patch to our repository.

Sounds good.  Please note the other issue Michel mentioned below.  We
need a fix for that as well for 5.7.

Thanks,

Alex

>
> Thanks
>
> On 04/06, Alex Deucher wrote:
> > On Mon, Apr 6, 2020 at 2:44 PM Rodrigo Siqueira
> > <Rodrigo.Siqueira at amd.com> wrote:
> > >
> > > Hi Michel,
> > >
> > > I'm going to apply the patchset by the end of the day at AMD repository.
> > > Is that ok for you? Or do you need this patch on drm-misc-next?
> >
> > I can cherry-pick the changes over to 5.7 fixes once we've addressed
> > all the issues.
> >
> > Alex
> >
> > >
> > > Best Regards
> > >
> > > On 04/06, Michel Dänzer wrote:
> > > > On 2020-04-05 10:41 p.m., Rodrigo Siqueira wrote:
> > > > > From: "Jerry (Fangzhi) Zuo" <Jerry.Zuo at amd.com>
> > > > >
> > > > > [Why]
> > > > > Prop are created at boot stage, and not allowed to create new prop
> > > > > after device registration.
> > > > >
> > > > > [How]
> > > > > Reuse the connector property from SST if exist.
> > > > >
> > > > > Signed-off-by: Jerry (Fangzhi) Zuo <Jerry.Zuo at amd.com>
> > > > > Reviewed-by: Hersen Wu <hersenxs.wu at amd.com>
> > > > > Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> > > > This patch is needed in 5.7, or one gets the WARNINGs I reported in
> > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Farchives%2Famd-gfx%2F2020-April%2F048017.html&data=02%7C01%7CRodrigo.Siqueira%40amd.com%7Cc277a51490f94ed99a2508d7da5af6f0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637217956540368991&sdata=%2FGtnTlXrRSzZM7M4KApZO1FFVCJjuJ8cur74s2ZNz0E%3D&reserved=0
> > > > when an MST display is connected.
> > > >
> > > > Note that this patch doesn't fix all of those, there's also one
> > > > triggered by dm_dp_add_mst_connector => drm_encoder_init.
> > > >
> > > >  git grep mst_encoders drivers/gpu/drm/i915/
> > > >
> > > > shows how the i915 driver deals with this.
> > > >
> > > > Can you guys take care of that for 5.7 as well?
> > > >
> > > >
> > > > --
> > > > Earthling Michel Dänzer               |               https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.com%2F&data=02%7C01%7CRodrigo.Siqueira%40amd.com%7Cc277a51490f94ed99a2508d7da5af6f0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637217956540373986&sdata=ckUT0WFeLWopbqY6SG%2Bg69i%2F3O6cTkSTWqBAyFHg3iw%3D&reserved=0
> > > > Libre software enthusiast             |             Mesa and X developer
> > >
> > > --
> > > Rodrigo Siqueira
> > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&data=02%7C01%7CRodrigo.Siqueira%40amd.com%7Cc277a51490f94ed99a2508d7da5af6f0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637217956540373986&sdata=%2BkwwR38PUel4j21WGo%2FxPMoXS%2BLnEQ4ax1yGxI%2F5xHc%3D&reserved=0
> > > _______________________________________________
> > > amd-gfx mailing list
> > > amd-gfx at lists.freedesktop.org
> > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CRodrigo.Siqueira%40amd.com%7Cc277a51490f94ed99a2508d7da5af6f0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637217956540373986&sdata=VlEy9R5us1VevQmtUJjen%2FrVoi0F8bjIAh%2FwffiCP2k%3D&reserved=0
>
> --
> Rodrigo Siqueira
> https://siqueira.tech


More information about the amd-gfx mailing list