[PATCH 2/2] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

Felix Kuehling felix.kuehling at amd.com
Tue Apr 7 16:08:51 UTC 2020


I don't know what happened to patch 3 in this last revision. Anyway, the
series is
Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>

Thanks,
  Felix

Am 2020-04-07 um 4:14 a.m. schrieb Jack Zhang:
> [PATCH 2/2]
> kfd_pre_reset will free mem_objs allocated by kfd_gtt_sa_allocate
>
> Without this change, sriov tdr code path will never free those
> allocated memories and get memory leak.
>
> Signed-off-by: Jack Zhang <Jack.Zhang1 at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index d94eff9..2e1f955 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3852,6 +3852,8 @@ static int amdgpu_device_reset_sriov(struct amdgpu_device *adev,
>  	if (r)
>  		return r;
>  
> +	amdgpu_amdkfd_pre_reset(adev);
> +
>  	/* Resume IP prior to SMC */
>  	r = amdgpu_device_ip_reinit_early_sriov(adev);
>  	if (r)


More information about the amd-gfx mailing list