[PATCH] drm/amdgpu: unify fw_write_wait for new gfx9 asics

Dai, Yuxian (David) Yuxian.Dai at amd.com
Wed Apr 8 06:51:15 UTC 2020


[AMD Official Use Only - Internal Distribution Only]

-----Original Message-----
From: Liu, Aaron <Aaron.Liu at amd.com> 
Sent: Wednesday, April 8, 2020 2:46 PM
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Huang, Ray <Ray.Huang at amd.com>; Dai, Yuxian (David) <Yuxian.Dai at amd.com>; Liu, Aaron <Aaron.Liu at amd.com>
Subject: [PATCH] drm/amdgpu: unify fw_write_wait for new gfx9 asics

Make the fw_write_wait default case true since presumably all new
gfx9 asics will have updated firmware. That is using unique WAIT_REG_MEM packet with opration=1.

Signed-off-by: Aaron Liu <aaron.liu at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 2d56b06722bc..1d18447129b1 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -1214,6 +1214,8 @@ static void gfx_v9_0_check_fw_write_wait(struct amdgpu_device *adev)
 			adev->gfx.mec_fw_write_wait = true;
 		break;
 	default:
+		adev->gfx.me_fw_write_wait = true;
+		adev->gfx.mec_fw_write_wait = true;
 		break;
 	}
 }
	[David]:
-             >much better solution
--
2.17.1


More information about the amd-gfx mailing list