[PATCH] drm/scheduler: fix drm_sched_get_cleanup_job

Kent Russell kent.russell at amd.com
Tue Apr 14 14:22:17 UTC 2020


From: Christian König <christian.koenig at amd.com>

We are racing to initialize sched->thread here, just always check the
current thread.

Signed-off-by: Christian Koenig <christian.koenig at amd.com>
Reviewed-by: Kent Russell <kent.russell at amd.com>
---
 drivers/gpu/drm/scheduler/sched_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 8e731ed0d9d9..2f319102ae9f 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -676,7 +676,7 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sched)
 	 */
 	if ((sched->timeout != MAX_SCHEDULE_TIMEOUT &&
 	    !cancel_delayed_work(&sched->work_tdr)) ||
-	    __kthread_should_park(sched->thread))
+	    kthread_should_park())
 		return NULL;
 
 	spin_lock(&sched->job_list_lock);
-- 
2.17.1



More information about the amd-gfx mailing list