[PATCH] drm/amd/powerplay: fix resume failed as smu table initialize early exit

Huang Rui ray.huang at amd.com
Fri Apr 17 02:29:42 UTC 2020


On Wed, Apr 15, 2020 at 11:43:24PM +0800, Liang, Prike wrote:
> When the amdgpu in the suspend/resume loop need notify the dpm disabled,
> otherwise the smu table will be uninitialize and result in resume failed.
> 
> Signed-off-by: Prike Liang <Prike.Liang at amd.com>
> Tested-by: Mengbing Wang <Mengbing.Wang at amd.com>

Reviewed-by: Huang Rui <ray.huang at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index 95eb445..7ddaea8 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -895,12 +895,17 @@ static int renoir_read_sensor(struct smu_context *smu,
>  
>  static bool renoir_is_dpm_running(struct smu_context *smu)
>  {
> +	struct amdgpu_device *adev = smu->adev;
> +
>  	/*
>  	 * Until now, the pmfw hasn't exported the interface of SMU
>  	 * feature mask to APU SKU so just force on all the feature
>  	 * at early initial stage.
>  	 */
> -	return true;
> +	if (adev->in_suspend)
> +		return false;
> +	else
> +		return true;
>  
>  }
>  
> -- 
> 2.7.4
> 


More information about the amd-gfx mailing list