[PATCH] drm/amdgpu: clean up unused variable about ring lru

Christian König ckoenig.leichtzumerken at gmail.com
Mon Apr 20 15:45:31 UTC 2020


Am 20.04.20 um 17:27 schrieb Kevin Wang:
> clean up unused variable:
> 1. ring_lru_list
> 2. ring_lru_list_lock
>
> related-commit:
> drm/amdgpu: remove ring lru handling
>
> Signed-off-by: Kevin Wang <kevin1.wang at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

Found by accident or used some tool? I'm asking because I'm pretty sure 
we have more like those.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 3 ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>   2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 94dff899248d..e8ab3dde6a66 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -953,9 +953,6 @@ struct amdgpu_device {
>   	/* link all shadow bo */
>   	struct list_head                shadow_list;
>   	struct mutex                    shadow_list_lock;
> -	/* keep an lru list of rings by HW IP */
> -	struct list_head		ring_lru_list;
> -	spinlock_t			ring_lru_list_lock;
>   
>   	/* record hw reset is performed */
>   	bool has_hw_reset;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 71ea56e220ae..38eb736091d0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2990,9 +2990,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>   	INIT_LIST_HEAD(&adev->shadow_list);
>   	mutex_init(&adev->shadow_list_lock);
>   
> -	INIT_LIST_HEAD(&adev->ring_lru_list);
> -	spin_lock_init(&adev->ring_lru_list_lock);
> -
>   	INIT_DELAYED_WORK(&adev->delayed_init_work,
>   			  amdgpu_device_delayed_init_work_handler);
>   	INIT_DELAYED_WORK(&adev->gfx.gfx_off_delay_work,



More information about the amd-gfx mailing list