[PATCH] drm: amdgpu: fix kernel-doc struct warning

Christian König christian.koenig at amd.com
Tue Apr 21 14:33:15 UTC 2020


Am 20.04.20 um 03:50 schrieb Randy Dunlap:
> Fix a kernel-doc warning of missing struct field desription:
>
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:92: warning: Function parameter or member 'vm' not described in 'amdgpu_vm_eviction_lock'

Can't we just document the function parameter instead? Should only be 
one IIRC.

Thanks,
Christian.

>
> Fixes: a269e44989f3 ("drm/amdgpu: Avoid reclaim fs while eviction lock")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Signed-off-by: Alex Sierra <alex.sierra at amd.com>
> Cc: Felix Kuehling <Felix.Kuehling at amd.com>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: David (ChunMing) Zhou <David1.Zhou at amd.com>
> Cc: amd-gfx at lists.freedesktop.org
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-57-rc2.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ lnx-57-rc2/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -82,7 +82,7 @@ struct amdgpu_prt_cb {
>   	struct dma_fence_cb cb;
>   };
>   
> -/**
> +/*
>    * vm eviction_lock can be taken in MMU notifiers. Make sure no reclaim-FS
>    * happens while holding this lock anywhere to prevent deadlocks when
>    * an MMU notifier runs in reclaim-FS context.



More information about the amd-gfx mailing list