[PATCH 2/2] drma/dmgpu: drop redundant cg/pg ungate on runpm enter

[Alex Deucher]

Also, I just noticed a typo in the patch title:

drma/dmgpu -> drm/admgpu

Alex

On Fri, Apr 24, 2020 at 4:06 AM Evan Quan <evan.quan at amd.com> wrote:
>
> CG/PG ungate is already performed in ip_suspend_phase1. Otherwise,
> the CG/PG ungate will be performed twice. That will cause gfxoff
> disablement is performed twice also on runpm enter while gfxoff
> enablemnt once on rump exit. That will put gfxoff into disabled
> state.
>
> Change-Id: I489ca456770d3fe482b685f132400202467f712b
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 08eeb0d2c149..71278942f9f0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3453,9 +3453,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool fbcon)
>                 }
>         }
>
> -       amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE);
> -       amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE);
> -
>         amdgpu_ras_suspend(adev);
>
>         r = amdgpu_device_ip_suspend_phase1(adev);
> --
> 2.26.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx