[PATCH 2/2] drma/dmgpu: drop redundant cg/pg ungate on runpm enter

[Quan, Evan]

Thanks. Corrected this on code submission.

Regards,
Evan
-----Original Message-----
From: Alex Deucher <alexdeucher at gmail.com> 
Sent: Friday, April 24, 2020 10:04 PM
To: Quan, Evan <Evan.Quan at amd.com>
Cc: amd-gfx list <amd-gfx at lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher at amd.com>; Kuehling, Felix <Felix.Kuehling at amd.com>; Liang, Prike <Prike.Liang at amd.com>
Subject: Re: [PATCH 2/2] drma/dmgpu: drop redundant cg/pg ungate on runpm enter

On Fri, Apr 24, 2020 at 10:02 AM Alex Deucher <alexdeucher at gmail.com> wrote:
>
> Also, I just noticed a typo in the patch title:
>
> drma/dmgpu -> drm/admgpu

Can't type.

drma/dmgpu -> drm/amdgpu

Alex

>
> Alex
>
> On Fri, Apr 24, 2020 at 4:06 AM Evan Quan <evan.quan at amd.com> wrote:
> >
> > CG/PG ungate is already performed in ip_suspend_phase1. Otherwise, 
> > the CG/PG ungate will be performed twice. That will cause gfxoff 
> > disablement is performed twice also on runpm enter while gfxoff 
> > enablemnt once on rump exit. That will put gfxoff into disabled 
> > state.
> >
> > Change-Id: I489ca456770d3fe482b685f132400202467f712b
> > Signed-off-by: Evan Quan <evan.quan at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index 08eeb0d2c149..71278942f9f0 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -3453,9 +3453,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool fbcon)
> >                 }
> >         }
> >
> > -       amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE);
> > -       amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE);
> > -
> >         amdgpu_ras_suspend(adev);
> >
> >         r = amdgpu_device_ip_suspend_phase1(adev);
> > --
> > 2.26.2
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fli
> > sts.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%
> > 7Cevan.quan%40amd.com%7Cca47ab8d659f48905ecd08d7e8584fd3%7C3dd8961fe
> > 4884e608e11a82d994e183d%7C0%7C0%7C637233338316990767&sdata=LqQrJ
> > Q3XTLmdCWvCKEpxOXEatrSjoswoQEb%2B7QDahGw%3D&reserved=0