[PATCH] drm/amdgpu: address the static checker warnings

[Quan, Evan]

Thanks, I think I get your point. With hive!= NULL, it never fails on the amdgpu_device_lock_adev().
Sorry for miss that. Will send a new patch.

Regards,
Evan
-----Original Message-----
From: Dan Carpenter <dan.carpenter at oracle.com> 
Sent: Tuesday, April 28, 2020 7:02 PM
To: Quan, Evan <Evan.Quan at amd.com>
Cc: amd-gfx at lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher at amd.com>
Subject: Re: [PATCH] drm/amdgpu: address the static checker warnings

On Tue, Apr 28, 2020 at 02:31:12AM +0000, Quan, Evan wrote:
> Ping..

Are you asking me?  It's really hard for me to read your emails.
Normally email clients put "> " in front of the quoted parts of the email.  Your email client doesn't line wrap at 72 characters either.  :(

> [Evan] No, that's true for SGPU setup only. For XGMI setup(multiple dgpus interconnected with bridges), the "hive" here is not NULL.

Presumably you are talking about out of tree code so I can't comment on this.  In the current linux-next we know that amdgpu_device_lock_adev() will only return false when "hive" is NULL.

regards,
dan carpenter