[PATCH] drm/amdgpu: fix uninit-value in arcturus_log_thermal_throttling_event()

[Alex Deucher]

On Thu, Aug 6, 2020 at 11:59 AM Kevin Wang <kevin1.wang at amd.com> wrote:
>
> when function arcturus_get_smu_metrics_data() call failed,
> it will cause the variable "throttler_status" isn't initialized before use.
>
> warning:
> powerplay/arcturus_ppt.c:2268:24: warning: ‘throttler_status’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>  2268 |   if (throttler_status & logging_label[throttler_idx].feature_mask) {
>
> Signed-off-by: Kevin Wang <kevin1.wang at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> index e58af84433c7..946dbc0db1b1 100644
> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> @@ -2253,14 +2253,17 @@ static const struct throttling_logging_label {
>  };
>  static void arcturus_log_thermal_throttling_event(struct smu_context *smu)
>  {
> +       int ret;
>         int throttler_idx, throtting_events = 0, buf_idx = 0;
>         struct amdgpu_device *adev = smu->adev;
>         uint32_t throttler_status;
>         char log_buf[256];
>
> -       arcturus_get_smu_metrics_data(smu,
> -                                     METRICS_THROTTLER_STATUS,
> -                                     &throttler_status);
> +       ret = arcturus_get_smu_metrics_data(smu,
> +                                           METRICS_THROTTLER_STATUS,
> +                                           &throttler_status);
> +       if (ret)
> +               return;
>
>         memset(log_buf, 0, sizeof(log_buf));
>         for (throttler_idx = 0; throttler_idx < ARRAY_SIZE(logging_label);
> --
> 2.27.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx